Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pom.xml #52

Closed
wants to merge 20 commits into from
Closed

update pom.xml #52

wants to merge 20 commits into from

Conversation

RobertMili
Copy link
Contributor

Update Maven plugin versions #7

@RobertMili RobertMili linked an issue Feb 8, 2023 that may be closed by this pull request
Update Maven plugin versions #7
Closed
@kappsegla
Copy link
Contributor

@RobertMili I think there are some files from .idea that shouldn't be included. Only the pom.xml should be changed.

@RobertMili RobertMili force-pushed the 7-update-maven-plugin-versions branch from 560c5e4 to f50ed08 Compare February 8, 2023 09:11
@RobertMili
Copy link
Contributor Author

@RobertMili I think there are some files from .idea that shouldn't be included. Only the pom.xml should be changed.

I did:

  1. Removed unnecessary files
  2. Committed
  3. Pushed to GitHub

@kappsegla
Copy link
Contributor

The empty file .idea/sonarlint/issuestore/index.pb should probably be removed?

Henrik-Bengtsson
Henrik-Bengtsson suggested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@Henrik-Bengtsson Henrik-Bengtsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of the core plugin are not specified in pom.xlm, maven-deploy-plugin and maven-site-plugin.

Under rules there are version 3.0, minimum requierment from specified plugins are 3.2.5. Newest version of maven are 3.9.0

One empty file in .idea are still left.

Your commits says unverified. Don't they need to be verified?

Should be an extra new line in the end of file.

@RobertMili
1. Added pom.xml file with plugins.
548c166 
2. Added dependencies from main.
@Henrik-Bengtsson
Copy link
Contributor

Compiler plugin are stated two times.

When I run mvn versions:display-plugin-updates I still get the warnings and error from previous review.

@RobertMili
1. Update rules -> 3.9
8648d58 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
@Henrik-Bengtsson
Copy link
Contributor

Compiler plugin are still entered two times, should remove the second one without configuration.

RobertMili and others added 11 commits February 13, 2023 11:02
@RobertMili
1. Update rules -> 3.9
bb38bd4 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
@RobertMili
1. Update rules -> 3.9
925298b 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
@RobertMili
1. Update rules -> 3.9
a95d312 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch
@RobertMili
1. Update rules -> 3.9
08e1234 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch.
@RobertMili
1. Update rules -> 3.9
bf4856b 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch..
@RobertMili
Merge branch 'main' into 7-update-maven-plugin-versions
05c54e1
@RobertMili
1. Update rules -> 3.9
2e989f2 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch
7. Delete two file
@RobertMili
Merge remote-tracking branch 'origin/7-update-maven-plugin-versions' …
58f07e8 
…into 7-update-maven-plugin-versions
@RobertMili
1. Update rules -> 3.9
0b6b0e3 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch
7. Delete two file
8. Change maven version to 3.8.1
@RobertMili
1. Update rules -> 3.9
59341e5 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch
7. Delete two file
8. Change maven version to 3.8.1
9. Ignoring *.impl files in target
@RobertMili
1. Update rules -> 3.9
7c8bb93 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch
7. Delete two file
8. Change maven version to 3.8.1
9. Ignoring *.impl files in target.
10. Removing haze.iml folder
Henrik-Bengtsson
Henrik-Bengtsson approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@Henrik-Bengtsson Henrik-Bengtsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RobertMili
1. Update rules -> 3.9
ce467e8 
2. adding  maven-deploy-plugin 3.0.0
3. adding  maven-site-plugin 4.0.0M
4. adding  extra new line on the end
5. removed second compiler plugin
6. Fixing conflict with main branch
7. Delete two file
8. Change maven version to 3.8.1
9. Ignoring *.impl files in target.
10. Removing haze.iml folder
11. squash commits
@RobertMili
Merge remote-tracking branch 'origin/7-update-maven-plugin-versions' …
d6d9db9 
…into 7-update-maven-plugin-versions
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RobertMili
Copy link
Contributor Author

I did new branch with verified account:

#97

@kappsegla kappsegla closed this Feb 13, 2023
@kappsegla kappsegla deleted the 7-update-maven-plugin-versions branch February 13, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Henrik-Bengtsson Henrik-Bengtsson Henrik-Bengtsson approved these changes

@safstromo safstromo safstromo approved these changes

@kappsegla kappsegla Awaiting requested review from kappsegla

@jLereback jLereback Awaiting requested review from jLereback

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Maven plugin versions
4 participants
@RobertMili @kappsegla @Henrik-Bengtsson @safstromo