32 feature handling more than one connection

[vonfredd]

Related Issue

Closes #32

Proposed Changes

Start a new thread when handling client connections

• Change 1: Refactored start method in Server class and create a new thread when connection needs to be handled.
• Change 2: ClientHandler.handleConnection now takes a socket as input parameter. The method is refactored.

[Win-ther]

It looks good if you remove the while-loop in clienthandler. It might have conflicts with #24 though?

[kappsegla]

This PR might have to make some changes after #24 is done and merged.

[Win-ther]

The client gets disconnected after connecting because isValidConnection runs every loop and returns false after first loop, closing the socket. Other than that the code looks good.

[vonfredd]

@kappsegla Do I add the tests in this PR to cover SonarCloud expectations, or do I create an issue that creates the tests for all the old and new classes before merging this?

[kappsegla]

@kappsegla Do I add the tests in this PR to cover SonarCloud expectations, or do I create an issue that creates the tests for all the old and new classes before merging this?

If we can write unit tests for the code they belong to the PR. It's a needed part both for our automatic CI but also for reviewers to check and learn how the new code is expected to work from.

[sonarcloud]

Quality Gate failed

Failed conditions

51.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[marcusju23]

Looks good! 👍

[Win-ther]

The code looks good and it works when I test it. Sonarclouds Quality Gate failed though, is this something we can ignore right now and merge anyway? Maybe something to look at in another issue?
I will approve right now since I want it to be able to merge if we can ignore the Qualite Gate.

[vonfredd]

The code looks good and it works when I test it. Sonarclouds Quality Gate failed though, is this something we can ignore right now and merge anyway? Maybe something to look at in another issue? I will approve right now since I want it to be able to merge if we can ignore the Qualite Gate.

The sonarcloud reacts because no old code has tests. So I also think that would be issued to fix, but ignored for now 😄 .