-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16 handling connections requests #24
Conversation
…f connection is valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isValidConnection method needs to return true. Other than that the code looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests could be done for isConnectPackage method in PackageReader class.
Absolutely , I will make some tests👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Handling connection request for the first time
We should validate the connections made according to MQTT protocol
Related Issue(s)
Closes #16
Proposed Changes
I suggest a separate class that can validate packages sent from a client to the server. The server can then respont to the client if connection is valid.
Here are some example changes: