Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Graph Banner Images for Mirlo #100

Closed
simonv3 opened this issue Sep 29, 2023 · 3 comments
Closed

Open Graph Banner Images for Mirlo #100

simonv3 opened this issue Sep 29, 2023 · 3 comments
Labels
Milestone

Comments

@simonv3
Copy link
Collaborator

simonv3 commented Sep 29, 2023

Can be tested here https://www.opengraph.xyz/url/https%3A%2F%2Fmirlo.space%2F

@simonv3 simonv3 added this to the MVP milestone Sep 29, 2023
@timglorioso timglorioso self-assigned this Oct 15, 2023
@simonv3
Copy link
Collaborator Author

simonv3 commented Nov 21, 2023

So I think this won't work with that URL specifically because netlify doesn't recognize those URLs as a user agent https://answers.netlify.com/t/support-guide-understanding-and-debugging-prerendering/150#which-requests-are-prerendered-1\\

best bet is to test it on discord or whatsapp (or facebook or twitter!)

@simonv3 simonv3 closed this as completed Nov 21, 2023
@bentooth
Copy link
Contributor

hmm. would we be open to hosting the client on the server? we could then inject the metadata based on the URL into the index.html being served? probably complicates things tho :/

@simonv3
Copy link
Collaborator Author

simonv3 commented Nov 22, 2023

Yeah, I'm not opposed and we'd need to do that as part of getting to self-install process (and also custom subdomains for artists). Switched to netlify for the reason of using prerendering #66

@timglorioso timglorioso removed their assignment Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants