Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picking up the correct tag for previous versions #111

Closed
j-i-l opened this issue May 23, 2024 · 0 comments · Fixed by #112
Closed

Picking up the correct tag for previous versions #111

j-i-l opened this issue May 23, 2024 · 0 comments · Fixed by #112
Assignees
@j-i-l

Comments

@j-i-l
Copy link
Collaborator

j-i-l commented May 23, 2024

In the last release #110 the PREVIOUS_VERSION was detected to be v3.0.7 where it should have been 3.1.0.

We are using git tag -l to fetch the tags and get the previous version. This approach might fail because of two reasons:

  • git tag -l returns a list in lexicographical order, thus a .12 would appear before a .2.
  • Up to version 3.0.7 the tags had the prefix v, so v3.0.7, which moves all of these tags at the bottom of the list.

See t4d-gmbh/stubbed_versioning#104 for how these two points can be addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-i-l j-i-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fetching correct tag for previous version furrer-lab/abn
1 participant
@j-i-l