Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Paper content #37

Merged
merged 42 commits into from
May 20, 2024
Merged

JOSS Paper content #37

merged 42 commits into from
May 20, 2024

Conversation

j-i-l
Copy link
Collaborator

@j-i-l j-i-l commented Mar 20, 2024

The branch JOSSpaper_noT gathers all paper specific content, including paper.md, paper.bib, etc.
Merge in main before submission. Do revisions during submission process on this branch then again.

Content that is relevant for abn package also outside the scope of the paper, but that was added/adapted/edited during the preparation of the paper should not reside in this branch.

@j-i-l
Copy link
Collaborator Author

j-i-l commented Mar 26, 2024

@matteodelucchi 9d4d8b9 is just a suggestion, feel free to revert or adapt :)

@j-i-l
Copy link
Collaborator Author

j-i-l commented Mar 26, 2024

@matteodelucchi
Copy link
Contributor

matteodelucchi commented Mar 26, 2024

@matteodelucchi I've also added a comment to https://github.com/orgs/furrer-lab/projects/1?pane=issue&itemId=57489555

thanks, reads better without the repetition. Implemented here 5eb1538

vignettes/paper.Rmd Outdated Show resolved Hide resolved
Merge main in JOSSpaper_noT
@matteodelucchi matteodelucchi marked this pull request as ready for review March 26, 2024 15:53
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (3884e6a) to head (5c3fd4b).
Report is 13 commits behind head on main.

Current head 5c3fd4b differs from pull request most recent head 71061ba

Please upload reports for the commit 71061ba to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files          53       53           
  Lines       10395    10395           
=======================================
  Hits         6891     6891           
  Misses       3504     3504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vignettes/paper.md Outdated Show resolved Hide resolved
vignettes/paper.md Outdated Show resolved Hide resolved
vignettes/paper.md Outdated Show resolved Hide resolved
vignettes/paper.md Outdated Show resolved Hide resolved
vignettes/paper.md Outdated Show resolved Hide resolved
@j-i-l j-i-l mentioned this pull request May 15, 2024
5 tasks
@j-i-l j-i-l self-assigned this May 20, 2024
@j-i-l j-i-l merged commit e031513 into main May 20, 2024
1 of 2 checks passed
@matteodelucchi matteodelucchi deleted the JOSSpaper_noT branch May 22, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants