Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split NonDet into Empty & Choose effects #199

Merged
merged 18 commits into from
Sep 21, 2019
Merged

Split NonDet into Empty & Choose effects #199

merged 18 commits into from
Sep 21, 2019

Conversation

robrix
Copy link
Contributor

@robrix robrix commented Aug 25, 2019 •
edited
Loading

This PR splits NonDet into separate Empty and Choose effects, handling both with the existing NonDet, Cut, and Cull carriers.

This was referenced Sep 1, 2019
Merged
Merged
Merged
Merged
@robrix robrix changed the base branch from nonempty-nondet to master September 18, 2019 23:57
robrix
robrix commented Sep 19, 2019
View reviewed changes
Copy link
Contributor Author

@robrix robrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say about this one since it’s a pretty straightforward consequence of #196 & #198, but: ready for review!

@robrix robrix marked this pull request as ready for review September 19, 2019 00:08
@robrix robrix merged commit 213218a into master Sep 21, 2019
@robrix robrix deleted the the-great-divide branch September 21, 2019 04:22
This was referenced Sep 21, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robrix