Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-resumable #269

Merged
merged 6 commits into from
Oct 19, 2019
Merged

Non-resumable #269

merged 6 commits into from
Oct 19, 2019

Conversation

robrix
Copy link
Contributor

@robrix robrix commented Oct 16, 2019

Copy link
Contributor Author

@robrix robrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review.

ChangeLog.md Outdated
@@ -52,6 +52,8 @@

- Redefines `Fail` as a synonym for `Throw String`. ([#247](https://github.com/fused-effects/fused-effects/pull/247))

- Removes `Resumable` and its carriers, as they can be more usefully and flexibly replaced by arbitrary effects, `Lift`, and `InterpretC`. ([#269](https://github.com/fused-effects/fused-effects/pull/269))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I鈥檓 honestly debating whether we need to re-home it or whether just removing it is fine.

We鈥檒l probably want to copy it into semantic as a short-term migration thing, but I don鈥檛 think it really deserves its own package鈥攖ho better options (e.g. coroutines) might.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move it to a package, and when we land a better solution (e.g. coroutines) we can mark the package as deprecated. That鈥檚 the most graceful solution, in my view, given that I bragged about Resumable at Strange Loop and I don鈥檛 want to renege on that particular promise. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that鈥檚 a good call 馃憤

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna hold off merging this PR until we have a repo & URL for that.

@robrix robrix marked this pull request as ready for review October 16, 2019 01:58
@robrix robrix changed the title Non resumable Non-resumable Oct 16, 2019
@robrix robrix added this to the 1.0 milestone Oct 16, 2019
@robrix robrix merged commit 1c2bdd5 into master Oct 19, 2019
@robrix robrix deleted the non-resumable branch October 19, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resumable doesn鈥檛 belong in the core library
2 participants