-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-resumable #269
Non-resumable #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review.
ChangeLog.md
Outdated
@@ -52,6 +52,8 @@ | |||
|
|||
- Redefines `Fail` as a synonym for `Throw String`. ([#247](https://github.com/fused-effects/fused-effects/pull/247)) | |||
|
|||
- Removes `Resumable` and its carriers, as they can be more usefully and flexibly replaced by arbitrary effects, `Lift`, and `InterpretC`. ([#269](https://github.com/fused-effects/fused-effects/pull/269)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I鈥檓 honestly debating whether we need to re-home it or whether just removing it is fine.
We鈥檒l probably want to copy it into semantic
as a short-term migration thing, but I don鈥檛 think it really deserves its own package鈥攖ho better options (e.g. coroutines) might.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move it to a package, and when we land a better solution (e.g. coroutines) we can mark the package as deprecated. That鈥檚 the most graceful solution, in my view, given that I bragged about Resumable
at Strange Loop and I don鈥檛 want to renege on that particular promise. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that鈥檚 a good call 馃憤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna hold off merging this PR until we have a repo & URL for that.
This PR 馃敟s
Resumable
.