Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-resumable #269

Merged
merged 6 commits into from
Oct 19, 2019
Merged

Non-resumable #269

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c83437a
:fire: Control.Carrier.Resumable.Resume.
robrix Oct 16, 2019
a140e16
:fire: Control.Carrier.Resumable.Either.
robrix Oct 16, 2019
4e40946
:fire: Control.Effect.Resumable.
robrix Oct 16, 2019
9ee4639
Add a note to the changelog.
robrix Oct 16, 2019
eedbec3
Merge branch 'master' into non-resumable
robrix Oct 19, 2019
48ddddc
Add an entry to the README.
robrix Oct 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@

- Redefines `Fail` as a synonym for `Throw String`. ([#247](https://github.com/fused-effects/fused-effects/pull/247))

- Removes `Resumable` and its carriers, as they can be more usefully and flexibly replaced by arbitrary effects, `Lift`, and `InterpretC`. ([#269](https://github.com/fused-effects/fused-effects/pull/269))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m honestly debating whether we need to re-home it or whether just removing it is fine.

We’ll probably want to copy it into semantic as a short-term migration thing, but I don’t think it really deserves its own package—tho better options (e.g. coroutines) might.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move it to a package, and when we land a better solution (e.g. coroutines) we can mark the package as deprecated. That’s the most graceful solution, in my view, given that I bragged about Resumable at Strange Loop and I don’t want to renege on that particular promise. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that’s a good call 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna hold off merging this PR until we have a repo & URL for that.


# v0.5.0.1

- Adds support for ghc 8.8.1.
Expand Down
3 changes: 0 additions & 3 deletions fused-effects.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ library
Control.Carrier.Pure
Control.Carrier.Reader
Control.Carrier.Resource
Control.Carrier.Resumable.Either
Control.Carrier.Resumable.Resume
Control.Carrier.State.Lazy
Control.Carrier.State.Strict
Control.Carrier.Throw.Either
Expand All @@ -84,7 +82,6 @@ library
Control.Effect.Pure
Control.Effect.Reader
Control.Effect.Resource
Control.Effect.Resumable
Control.Effect.State
Control.Effect.Sum
Control.Effect.Throw
Expand Down
75 changes: 0 additions & 75 deletions src/Control/Carrier/Resumable/Either.hs
View file
Open in desktop

This file was deleted.

53 changes: 0 additions & 53 deletions src/Control/Carrier/Resumable/Resume.hs
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions src/Control/Effect/Resumable.hs
View file
Open in desktop

This file was deleted.