ghc 8.10 #376
Merged
ghc 8.10 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can’t really do anything about these, cabal build will still report any we *can* act on, and it’s just noise for the repl/ghcide integration.
patrickt
reviewed
Mar 31, 2020
| @@ -23,8 +23,16 @@ | |||
| :seti -Wno-name-shadowing | |||
| :seti -Wno-safe | |||
| :seti -Wno-unsafe | |||
|
|
|||
| -- ghc 8.6+ | |||
| :seti -Wno-star-is-type | |||
There was a problem hiding this comment.
Could we ditch this particular clause entirely, since I think we've switched to using Type everywhere?
There was a problem hiding this comment.
We did this on master for 1.1, this PR is going to release 1.0.2.1.
|
I’m not sure why the CI isn’t running 😕 Maybe closing and reopening the PR would help? In any case, this is ready to go; it compiles fine with 8.10. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master.Currently blocked on:
inspection-testing