Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc 8.10 #376

Merged
merged 12 commits into from
Jun 16, 2020
Merged

ghc 8.10 #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7499981
Bump the upper bound on base.
robrix Mar 30, 2020
77be5e2
Disable the warnings in ghc 8.10.
robrix Mar 30, 2020
9b295c6
Disable undesirable new warnings in builds.
robrix Mar 30, 2020
06ab59c
Add headings for the version-specific warning flags in .ghci.repl.
robrix Mar 30, 2020
4280777
Disable undesirable new warnings in the repl.
robrix Mar 30, 2020
6cf02aa
Disable undesirable new warnings in ghcide.
robrix Mar 30, 2020
9b95afa
Disable -Wunused-packages in script/ghci-flags.
robrix Mar 30, 2020
86e1cd8
Bump the package version.
robrix Mar 30, 2020
b8ae6f2
Tentative release notes.
robrix Mar 30, 2020
08b62bf
Link to the PR.
robrix Mar 30, 2020
4050fe2
Add GHC 8.10 to CI.
patrickt Apr 17, 2020
757f481
Wrong version.
patrickt Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .ghci.repl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,16 @@
:seti -Wno-name-shadowing
:seti -Wno-safe
:seti -Wno-unsafe

-- ghc 8.6+
:seti -Wno-star-is-type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ditch this particular clause entirely, since I think we've switched to using Type everywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did this on master for 1.1, this PR is going to release 1.0.2.1.


-- ghc 8.8+
:seti -Wno-missing-deriving-strategies

-- ghc 8.10+
:seti -Wno-missing-safe-haskell-mode
:seti -Wno-prepositive-qualified-module

-- We have this one on in the project but not in the REPL to reduce noise
:seti -Wno-type-defaults
2 changes: 1 addition & 1 deletion .github/workflows/haskell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-16.04
strategy:
matrix:
ghc: ["8.2.2", "8.4.4", "8.6.5", "8.8.2"]
ghc: ["8.2.2", "8.4.4", "8.6.5", "8.8.2", "8.10.1"]
cabal: ["3.0"]

steps:
Expand Down
5 changes: 5 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# v1.0.2.1

- Adds support for `ghc` 8.10 & `base` 4.14. ([#376](https://github.com/fused-effects/fused-effects/pull/376))


# v1.0.2.0

- Adds a `state` operation for the `State` effect. ([#353](https://github.com/fused-effects/fused-effects/pull/353))
Expand Down
9 changes: 7 additions & 2 deletions fused-effects.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cabal-version: 2.2

name: fused-effects
version: 1.0.2.0
version: 1.0.2.1
synopsis: A fast, flexible, fused effect system.
description: A fast, flexible, fused effect system, à la Effect Handlers in Scope, Monad Transformers and Modular Algebraic Effects: What Binds Them Together, and Fusion for Free—Efficient Algebraic Effect Handlers.
homepage: https://github.com/fused-effects/fused-effects
Expand All @@ -21,6 +21,7 @@ tested-with:
GHC == 8.4.4
GHC == 8.6.5
GHC == 8.8.3
GHC == 8.10.1

common common
default-language: Haskell2010
Expand All @@ -39,6 +40,10 @@ common common
ghc-options: -Wno-star-is-type
if (impl(ghc >= 8.8))
ghc-options: -Wno-missing-deriving-strategies
if (impl(ghc >= 8.10))
ghc-options:
-Wno-missing-safe-haskell-mode
-Wno-prepositive-qualified-module

library
import: common
Expand Down Expand Up @@ -97,7 +102,7 @@ library
Control.Effect.Throw.Internal
Control.Effect.Writer.Internal
build-depends:
base >= 4.9 && < 4.14
base >= 4.9 && < 4.15
, transformers >= 0.4 && < 0.6


Expand Down
5 changes: 3 additions & 2 deletions script/ghci-flags
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ function flags {
echo "-Wno-name-shadowing"
echo "-Wno-safe"
echo "-Wno-unsafe"
[[ "$ghc_version" = 8.6.* ]] || [[ "$ghc_version" = 8.8.* ]] && echo "-Wno-star-is-type" || true
[[ "$ghc_version" = 8.8.* ]] && echo "-Wno-missing-deriving-strategies" || true
[[ "$ghc_version" = 8.6.* ]] || [[ "$ghc_version" = 8.8.* ]] || [[ "$ghc_version" = 8.10.* ]] && echo "-Wno-star-is-type" || true
[[ "$ghc_version" = 8.8.* ]] || [[ "$ghc_version" = 8.10.* ]] && echo "-Wno-missing-deriving-strategies" || true
[[ "$ghc_version" = 8.10.* ]] && echo "-Wno-missing-safe-haskell-mode" && echo "-Wno-prepositive-qualified-module" && echo "-Wno-unused-packages"
}

flags > "$output_file"