Derive MonadFix for labelled effects #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the CI failures, merging There aren’t any other changes pending on |
robrix
suggested changes
Dec 7, 2020
|
@robrix I added the |
JaSpa
commented
Dec 9, 2020
Comment on lines
+50
to
+60
| deriving | ||
| ( Alternative | ||
| , Applicative | ||
| , Functor | ||
| , Monad | ||
| , Fail.MonadFail | ||
| , MonadFix -- ^ @since 1.1.1 | ||
| , MonadIO | ||
| , MonadPlus | ||
| , MonadTrans | ||
| ) |
There was a problem hiding this comment.
I think breaking this into multiple lines is cleaner than an inline comment …, MonadFix {- ^ @since 1.1.1 -}, …
robrix
approved these changes
Dec 10, 2020
|
1.1.1 has been released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other carriers already define a conditional
MonadFixinstance.These instances should probably get a
@since XXannotation and maybe an entry in the changelog. What is your process in that regard? I can add those if you can tell me what the next version number will be or alternatively add some kind of placeholder to fill in when the next release is done.