-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive MonadFix for labelled effects #402
Conversation
For the CI failures, merging There aren’t any other changes pending on |
@robrix I added the |
deriving | ||
( Alternative | ||
, Applicative | ||
, Functor | ||
, Monad | ||
, Fail.MonadFail | ||
, MonadFix -- ^ @since 1.1.1 | ||
, MonadIO | ||
, MonadPlus | ||
, MonadTrans | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think breaking this into multiple lines is cleaner than an inline comment …, MonadFix {- ^ @since 1.1.1 -}, …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ perfect, thank you so much!
1.1.1 has been released! |
All other carriers already define a conditional
MonadFix
instance.These instances should probably get a
@since XX
annotation and maybe an entry in the changelog. What is your process in that regard? I can add those if you can tell me what the next version number will be or alternatively add some kind of placeholder to fill in when the next release is done.