Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances for Choosing #419

Conversation

robrix
Copy link
Contributor

@robrix robrix commented Feb 27, 2022

This PR defines/derives a number of instances for Control.Effect.Choose.Choosing.

These instances, much like the similar ones for Alt and Ap, allow us to build values in Choosing using effect operators directly, rather than requiring that the operators be wrapped in Choosing constructions manually.

@robrix robrix marked this pull request as ready for review February 27, 2022 21:15
@robrix robrix requested a review from a team February 27, 2022 22:55
Copy link
Collaborator

@patrickt patrickt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait, can you add a Changelog entry?

@robrix
Copy link
Contributor Author

robrix commented Feb 28, 2022

@patrickt: Good catch. Changelog entry added.

@patrickt patrickt merged commit 2b3d193 into master Mar 2, 2022
@patrickt patrickt deleted the you-can-choose-your-friends-but-you-(probably)-can't-choose-your-nose branch March 2, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants