Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MonadUnliftIO instances for eligible carrier types. #420

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Add MonadUnliftIO instances for eligible carrier types. #420

merged 4 commits into from
Mar 2, 2022

Conversation

patrickt
Copy link
Collaborator

@patrickt patrickt commented Feb 28, 2022 •
edited

As per @shinzui and @ocharles's request, and given that unliftio-core has a
very small dependency footprint, we've decided to add MonadUnliftIO instances.

/hattip @ocharles for demonstrating that InterpretC supports this in #406.

@patrickt
Add MonadUnliftIO instances for eligible carrier types.
5f1d35a 
As per @shinzui and @ocharles's request, and given that `unliftio-core` has a
very small dependency footprint, we've decided to add `MonadUnliftIO` instances.

/hattip @ocharles for demonstrating that `InterpretC` supports this in #408.
@shinzui
Copy link
Contributor

shinzui commented Feb 28, 2022

Thank you, @patrickt.

@patrickt patrickt requested a review from robrix February 28, 2022 18:04
robrix
robrix suggested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@robrix robrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few notes.

ChangeLog.md Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
src/Control/Carrier/Interpret.hs
@@ -33,6 +33,7 @@ import Control.Monad.Fail as Fail
import Control.Monad.Fix
import Control.Monad.IO.Class
import Control.Monad.Trans.Class
import Control.Monad.IO.Unlift (MonadUnliftIO)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whichever of this PR and #419 gets merged first should make sure to derive an instance for Choosing as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…and should note it in the changelog.

src/Control/Carrier/Reader.hs Outdated Show resolved Hide resolved
src/Control/Carrier/Reader.hs Show resolved Hide resolved
robrix
robrix suggested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@robrix robrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot this one.

ChangeLog.md Outdated Show resolved Hide resolved
patrickt and others added 2 commits March 1, 2022 14:06
@patrickt @robrix
Apply suggestions from code review
a9988e6 
Co-authored-by: Rob Rix <rob.rix@me.com>
@patrickt
More suggestions.
b8fe523
@patrickt patrickt requested a review from robrix March 1, 2022 19:12
@patrickt patrickt merged commit b447986 into master Mar 2, 2022
@patrickt patrickt deleted the monadunliftio branch March 2, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrix robrix robrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickt @shinzui @robrix