Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub based CI not uploading to codecov #23

Closed
shimwell opened this issue Jul 13, 2021 · 4 comments · Fixed by #72
Closed

GitHub based CI not uploading to codecov #23

shimwell opened this issue Jul 13, 2021 · 4 comments · Fixed by #72

Comments

@shimwell
Copy link
Member

There is a line in one of the github actions that is broken

This line should upload to codecov

curl -s https://codecov.io/bash

However the actions logs show that it is not working.

This is perhaps because it is running in a container and something needs changing to get it to work correctly

So currently the CircleCi tests are reporting the coverage

@shimwell
Copy link
Member Author

Looks like one method is to use the codecov action https://github.com/codecov/codecov-action

@RemDelaporteMathurin
Copy link
Member

In the circleCI yml file, the command to be run is:

- run: bash <(curl -s https://codecov.io/bash)

is it not simply missing the bash thing?

@shimwell
Copy link
Member Author

shimwell commented Aug 25, 2021

One method I've used on another repo is to share a folder between the docker image and the base runner

https://github.com/openmc-data-storage/openmc_data_downloader/blob/59f40706f6653c7721eacb8185390bf43226dc06/.github/workflows/docker_ci_main.yml#L16-L24

the pytest commands also moved the report to the shared folder

https://github.com/openmc-data-storage/openmc_data_downloader/blob/59f40706f6653c7721eacb8185390bf43226dc06/Dockerfile#L12

@RemDelaporteMathurin RemDelaporteMathurin linked a pull request Aug 26, 2021 that will close this issue
10 tasks
@shimwell
Copy link
Member Author

We can upload to code coverage now, but will stick with circle ci. Good to have another option though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants