Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behaviour when use an existing secret and databbase root password #48

Closed
jrpedrianes opened this issue May 6, 2021 · 3 comments

Comments

@jrpedrianes
Copy link

If we use an existing secret to store credentials, the modifications included in #43 forces us to add a dummy database root password.

This behaviour is a bit strange, maybe would be better to add a new helm value to force the environment mapping, or change the way the secrets are included as environment variables, ie, map a secret as environment variables directly: https://kubernetes.io/docs/concepts/configuration/secret/#use-cases

@drpebcak
Copy link
Contributor

drpebcak commented May 6, 2021

I've opened a PR to address this. Please take a look if you get a chance.

@jrpedrianes
Copy link
Author

LGTM, now I think it is more consistent to do it in that way

@drpebcak
Copy link
Contributor

Closing as #49 is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants