Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying attr for the non-availableAnim attributes #65

Closed
AyanGhatak opened this issue Apr 30, 2016 · 2 comments
Closed

Applying attr for the non-availableAnim attributes #65

AyanGhatak opened this issue Apr 30, 2016 · 2 comments

Comments

@AyanGhatak
Copy link
Contributor

In redraphael, we have a list of availableAnimAttrs e.g. "stroke-opacity", ""stroke-width", etc. Apart from these other attributes are not even applied if asked to animate.

To illustrate the fact, say elem is the concerned element,

elem.animate({ path: <Array>, 'stroke-opacity': <Number>, 'stroke-dasharray': <Array>, 'stroke-linecap': <String> }, <animDuration>)

As path and 'stroke-opacity' are animatable or to say at present, we have a support for them, gets applied with an animation but for the other two attributes(namely 'stroke-dasharray' and 'stroke-linecap') do not even get applied as:

elem.attr({ 'stroke-dasharray': <Array>, 'stroke-linecap': <String> })

That is where I suggest some improvement. We do not have code for supporting animation of these attributes, thats fine, but if an user gives it should at least get applied.

@adotg
Copy link
Contributor

adotg commented May 3, 2016

This is a very required feature since the caller module would not have to take separate care for the non-animatable properties. Advantage if this is fixed properly are more separation of concern and reduced code lines.

@AyanGhatak
Copy link
Contributor Author

Closing the issue after the PR is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants