Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex misses figcaption #33

Closed
thartl opened this issue Nov 19, 2022 · 2 comments
Closed

Regex misses figcaption #33

thartl opened this issue Nov 19, 2022 · 2 comments

Comments

@thartl
Copy link
Contributor

thartl commented Nov 19, 2022 •
edited
Loading

The regex patterns in lyte_prepare() do not account for css classes core added to figcaption.
Replacing <figcaption> in both patterns with <figcaption.*> fixes this.
@futtta
Copy link
Owner

futtta commented Nov 20, 2022

feel free to do a pull request @thartl (unless if you prefer me to simply get on with it off course) :-)

@thartl
Copy link
Contributor Author

thartl commented Nov 20, 2022

Okay, done.
Thank you for the quick response and a great plugin :)

@thartl thartl closed this as completed Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@futtta @thartl