Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the same id in SCTE-OUT/IN pairs inside EXT-X-DATERANGE, as specified in the hls standard #20

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

chreniuc
Copy link
Contributor

#19

The hls standard states that:

An SCTE-35 splice out/in pair signaled by a pair of splice_insert()
commands SHOULD be represented by one or more EXT-X-DATERANGE tags
carrying the same ID attribute, which MUST be unique to that splice
out/in pair.

https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-4.4.5.1.1

This tool generates that pair with different ids for each scte command.

@chreniuc
Copy link
Contributor Author

The id will be incremented at the end of each pair(when scte-in is generated)

Copy link
Owner

@futzu futzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@futzu futzu merged commit 4217f99 into futzu:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants