Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m3u8 live window fix #28

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

edward-rafalovsky
Copy link
Contributor

Live window sliding should be independent from the --delete param

Copy link
Owner

@futzu futzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget what I just said, my brain is on a low setting today.

@futzu
Copy link
Owner

futzu commented Dec 4, 2023

Would you make two changes?

  1. Remove this line from popleft_panes
        if len(self.panes) >= self.size:

That doesn't need to be there,
the size is checked in slide_panes.
Which brings us to the second change.

  1. Fix my other error in slide_panes
    This is what slide_panes needs to look like.
    def slide_panes(self, a_pane=None):
        if a_pane:
            self.push_pane(a_pane)                                      
        while len(self.panes) > self.size:
                self.popleft_pane()

Right now I have

    def slide_panes(self, a_pane=None):
        if a_pane:
            self.push_pane(a_pane)
        if self.delete:              # This line is wrong. 
            while len(self.panes) > self.size:
                self.popleft_pane()

If you'll do that for me, I accept the patch and new release.

@futzu
Copy link
Owner

futzu commented Dec 4, 2023

I got it. Dont worry about the changes.
You're a php guy? I thought y'all were extinct. :)

@futzu futzu merged commit 04b47e0 into futzu:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants