Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packaging for different OS than host #13

Closed
jdimeo opened this issue Jan 9, 2020 · 3 comments
Closed

Allow packaging for different OS than host #13

jdimeo opened this issue Jan 9, 2020 · 3 comments

Comments

@jdimeo
Copy link

jdimeo commented Jan 9, 2020

Instead of automatically packaging for the host OS, I would like to be able to specify which OS to build for. I've used a Windows host to build both a .exe and a Mac .app bundle. You can build more than one package with multiple executions of the plugin.

I've committed some code to do this on my fork:
https://github.com/ElderResearch/JavaPackager/commit/96bf664ba0764c0161dd9a280d0a16a1e1d3cbe0

This introduces a new platform configuration, one of:
auto (the default- current behavior)
mac
linux
windows

Let me know if you want me to open a PR

@fvarrui
Copy link
Owner

fvarrui commented Jan 10, 2020

Hi,
I like how you refactored Mojo's execute method. It's cleaner than before.

The generation of the appropriate installer for each platform depends on the platform where JavaPackager is running, so it will be necessary to verify that if the target platform is different than current platform, the installer cannot be generated.

Thanks!

@fvarrui
Copy link
Owner

fvarrui commented Jan 14, 2020

And I’ve just realized that a customized JRE couldn’t be bundled

@fvarrui
Copy link
Owner

fvarrui commented Jan 16, 2020

Fixed in v0.8.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants