Fix uninitialized variable in FvwmIconMan colorset loop. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FvwmIconMan, using colorsets to set various styles (e.g., PlainColorset, SelectColorset, etc.) is broken. Essentially, background colors for one color end up being mapped to the shadow color of the previously used colorset. This is because the loop that calls fvwmlib_XCreateGC on the various colorsets does not happen to set the background color from the colorset inside the loop. This makes the code function OK with just one colorset, but adding a second colorset in your settings causes problems. This change explicitly set the background color on the GC within the loop, so as to not carry forth the shadow color from the end of the previous iteration.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FvwmIconMan, using colorsets to set various styles (e.g., PlainColorset,
SelectColorset, etc.) is broken. Essentially, background colors for one color
end up being mapped to the shadow color of the previously used colorset. This
is because the loop that calls fvwmlib_XCreateGC on the various colorsets does
not happen to set the background color from the colorset inside the loop. This
makes the code function OK with just one colorset, but adding a second colorset
in your settings causes problems.
This change explicitly set the background color on the GC within the loop, so as
to not carry forth the shadow color from the end of the previous iteration.