-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EdgeScroll: implement per monitor #916
Conversation
Tested this out and it works as described. I am able to control It would also be nice to have a way to turn panframes on/off on a per-monitor basis as well. I use |
Yeah -- OK, that's a good point. Because the panframes still exist with setting I'll add that in with this PR. Note that the semantics of all of this is getting weird, with So I think what I'm suggesting is to achieve what you want, it is going to have to be a combination of a few different commands, but you can always put them in a function, perhaps passing in the monitor name to toggle these things on/off. |
Right, this PR now allows for:
Which will completely disable the ability to switch pages and drag windows on the specified monitor. Not specifying the Please do test it, and let me know how you get on. I'll update the man page bits in due course. |
a0094e1
to
89ff654
Compare
I notice a few issues with this, first |
Actually |
Huh. Yeah, OK. Fix incoming... |
89ff654
to
0791b5b
Compare
Try that, when you get a mo... |
There is still some oddness going on, but harder to describe. In short it starts out working just fine, but after toggling |
Odd -- thanks for checking. I'll add some logging to see where it's getting stuck. |
Some more tests, I run |
For what it is worth, I have two monitors with same resolution positioned left/right and the following setup, so I can scroll up and down on each monitor.
|
Thanks, @somiaj I think this might have been due to a former check which tried to be clever about how to map/unmap the pan frames. Now that Edge{Scroll,Thickness} can always change the state of these, it's not too expensive to recreate them on-the-fly. So I've removed this check, just to see if that makes a difference. From what I can tell here, it seems to. |
My initial tests seem to confirm it is now working, I will use this for a few days to see if I have any more issues. |
Again so far, so good. Now scroll lock can toggle scrolling on a per monitor basis.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been using this for a little bit now, and it seems to work. I say it is good to go (though maybe rename the WIP in the commit name).
Bring the EdgeScroll command inline with other command, such as EwmhBaseStruts whereby the dimensions can be specified per-monitor, such as: EdgeScroll 0 0 EdgeScroll screen DP-1 100 100
Rather than having a global value to represent the state of edgethickness, make this a part of the monitor struct, so it can be changed per-monitor.
This check was an optimisation, but now that Edge{Scroll,Thickness} can change this, we should let the commands figure out for themselves when to map/unmap.
0e29ad3
to
927fd66
Compare
Thanks, @somiaj -- merging this now to |
Bring the EdgeScroll command inline with other command, such as
EwmhBaseStruts whereby the dimensions can be specified per-monitor, such
as: