FvwmPager: honour screen focus rules #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When FvwmPager is configured without the `Monitor` module config line, *and*, `DesktopConfiguration per-monitor` is set, FvwmPager wasn't tracking which monitor should be used to invoke the `GotoDesk` command when clicking on the pager desk label. This meant desktops had the effect of not switching. This change won't affect `DesktopConfiguration global`, and will work when FvwmPager has a `Monitor` configuration line. Fixes #957
When invoking the GotoDesk or GotoDeskAndPage commands such as:
GotoDesk 0 0
GotoDeskAndPage 0 0 1
... this would be invalid because the first argument is treated as a
screen identifier, which then fails the rest of the command.
In such cases, inject the screen name of the current monitor if it's
missing.
Fixes #941
Fixes #957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FvwmPager is configured without the
Monitormodule config line,and,
DesktopConfiguration per-monitoris set, FvwmPager wasn'ttracking which monitor should be used to invoke the
GotoDeskcommandwhen clicking on the pager desk label.
This meant desktops had the effect of not switching.
This change won't affect
DesktopConfiguration global, and will workwhen FvwmPager has a
Monitorconfiguration line.Fixes #957