Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three tests fail because of some timezone issue #18

Closed
timhabermaas opened this issue Oct 2, 2014 · 4 comments · Fixed by #28
Closed

Three tests fail because of some timezone issue #18

timhabermaas opened this issue Oct 2, 2014 · 4 comments · Fixed by #28

Comments

@timhabermaas
Copy link
Collaborator

  1) Failure:
Admin::NewsControllerTest#test_#create [/Users/tim/Projects/cubecomp/test/controllers/admin/news_controller_test.rb:44]:
--- expected
+++ actual
@@ -1 +1 @@
-2014-09-11 11:30:00 +0200
+Thu, 11 Sep 2014 11:30:00 UTC +00:00



  2) Failure:
Admin::NewsControllerTest#test_#update [/Users/tim/Projects/cubecomp/test/controllers/admin/news_controller_test.rb:68]:
--- expected
+++ actual
@@ -1 +1 @@
-2014-09-11 11:30:00 +0200
+Thu, 11 Sep 2014 11:30:00 UTC +00:00



  3) Failure:
Admin::EventsControllerTest#test_#update [/Users/tim/Projects/cubecomp/test/controllers/admin/events_controller_test.rb:69]:
Expected: "13:00"
  Actual: "15:00"

222 runs, 711 assertions, 3 failures, 0 errors, 0 skips
@fw42
Copy link
Owner

fw42 commented Oct 4, 2014

Oh, hm. They pass for me (probably because my development VM is in UTC)... Not sure what the reason is.

@fw42
Copy link
Owner

fw42 commented Oct 4, 2014

I think the right solution is probably to add a timezone attribute to competitions and then use that timezone when interpreting news and events for that competition

@fw42
Copy link
Owner

fw42 commented Oct 4, 2014

or try to be smart and derive the timezone from the competition's country

@fw42
Copy link
Owner

fw42 commented Oct 4, 2014

or force everything to UTC and not give a shit :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants