Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CBOR string validation error from SemanticError to SyntaxError #56

Closed
fxamacker opened this issue Dec 3, 2019 · 0 comments
Closed

Change CBOR string validation error from SemanticError to SyntaxError #56

fxamacker opened this issue Dec 3, 2019 · 0 comments
Labels
bug Something isn't working
Milestone
v1.3.3

Comments

@fxamacker
Copy link
Owner

Valid() should return SyntaxError instead of SemanticError when:

  • indefinite length string chunks are not of the same type, or
  • indefinite length string chunks are not definite length.

Probably no difference except for logs. So this won't require a bugfix release.
@fxamacker fxamacker added the bug Something isn't working label Dec 3, 2019
@fxamacker fxamacker added this to the v1.4.0 milestone Dec 3, 2019
@fxamacker fxamacker modified the milestones: v2.0.0, v1.3.3 Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.3.3
Development

No branches or pull requests
1 participant
@fxamacker