Bug 1112131 - Start end attributes rtl friendly #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
force-pushed
the
start-end-attributes-rtl-friendly
branch
from
57240a1
to
03abcb8
Compare
| @@ -375,7 +366,7 @@ module.exports = Component.register('gaia-header', { | |||
| * @private | |||
| */ | |||
| isSupportedAction: function(action) { | |||
| return action && actionTypes[action]; | |||
| return !!(action && actionTypes[action]); | |||
There was a problem hiding this comment.
This was breaking "toggle" when action was undefined; now we always return a real boolean
julienw
force-pushed
the
start-end-attributes-rtl-friendly
branch
from
03abcb8
to
2335cc4
Compare
| */ | ||
| var privMap = new WeakMap(); | ||
|
|
||
| function getPriv(instance) { |
There was a problem hiding this comment.
This seems like quite a complicated way to cache start and end attributes? Can't we just store them on the heading instance?
heading.dataset.start = start;
heading.dataset.end = end;
julienw
force-pushed
the
start-end-attributes-rtl-friendly
branch
2 times, most recently
from
f9ea303
to
4a573f7
Compare
| } | ||
|
|
||
| if (width !== undefined) { | ||
| priv.width = width; |
There was a problem hiding this comment.
:D was very rough draft ;)
julienw
force-pushed
the
start-end-attributes-rtl-friendly
branch
from
4a573f7
to
cc77a70
Compare
| @@ -18,6 +18,8 @@ require('gaia-icons'); | |||
| */ | |||
| var actionTypes = { menu: 1, back: 1, close: 1 }; | |||
|
|
|||
| const KNOWN_ATTRIBUTES = ['action', 'available-width', 'no-font-fit', 'title-start', 'title-end']; | |||
There was a problem hiding this comment.
So, the available-width is not used or am I missing something?
* simplify the definition of the attrs attribute using an external function * sanitize the attribute values in the setter * use the attribute getter instead of acessing the raw value * remove side effects from merely setting a value, allowing to use the value sanitizer from the "created" method. * Do not run reformatHeading when start/end are set, if no-font-fit is set. * Fix the implementation for "available-width" * Add more unit tests, especially for "available-width" behavior
julienw
force-pushed
the
start-end-attributes-rtl-friendly
branch
from
cc77a70
to
4041f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.