Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1112131 - Start end attributes rtl friendly #16

Closed
wants to merge 9 commits into from
Closed

Bug 1112131 - Start end attributes rtl friendly #16

wants to merge 9 commits into from

Commits on Jan 6, 2015

  1. abstract out attributes handling

    @julienw
    julienw committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    3b26426 View commit details
    Browse the repository at this point in the history

  2. rework initialization steps

    @julienw
    julienw committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    ee88b52 View commit details
    Browse the repository at this point in the history

  3. add a skip init attribute

    @julienw
    julienw committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    4c636e3 View commit details
    Browse the repository at this point in the history

  4. implement start and end attributes

    @julienw
    julienw committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    cd3268c View commit details
    Browse the repository at this point in the history

  5. make start and end rtl friendly

    @julienw
    julienw committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    9e710ec View commit details
    Browse the repository at this point in the history

  6. use attrs from gaia-component instead of custom KNOWN_ATTRIBUTES mech… 

    …anism
    @julienw
    julienw committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    02c3afc View commit details
    Browse the repository at this point in the history

  7. add available width attribute

    @julienw
    julienw committed Jan 6, 2015
    Configuration menu
    Copy the full SHA
    3479690 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2015

  1. Follow-ups: 

    * simplify the definition of the attrs attribute using an external function
* sanitize the attribute values in the setter
* use the attribute getter instead of acessing the raw value
* remove side effects from merely setting a value, allowing to use the value
  sanitizer from the "created" method.
* Do not run reformatHeading when start/end are set, if no-font-fit is set.
* Fix the implementation for "available-width"
* Add more unit tests, especially for "available-width" behavior
    @julienw
    julienw committed Jan 9, 2015
    Configuration menu
    Copy the full SHA
    48fd019 View commit details
    Browse the repository at this point in the history

  2. updated build package

    @julienw
    julienw committed Jan 9, 2015
    Configuration menu
    Copy the full SHA
    4041f27 View commit details
    Browse the repository at this point in the history