Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Paths #3

Closed
AlbinoGeek opened this issue Dec 13, 2020 · 2 comments
Closed

Import Paths #3

AlbinoGeek opened this issue Dec 13, 2020 · 2 comments

Comments

@AlbinoGeek
Copy link
Contributor

AlbinoGeek commented Dec 13, 2020 •
edited
Loading

Neither of the import paths produce the correct meta tags:

Code Meta URL
404 missing https://fyne.io/fyne/x/layout?go-get=1
404 missing https://fyne.io/fyne/x/widget?go-get=1
404 missing https://fyne.io/fyne/x?go-get=1
301 missing https://fyne.io/fyne?go-get=1

The URL https://fyne.io/fyne/x?go-get=1 should have the following:

<meta name="go-import" content="import-prefix git github.com/fyne-io/fyne-x">

As per documentation:

https://golang.org/cmd/go/#hdr-Remote_import_paths

This is needed to fix the govet CI test, and merge PRs.
@andydotxyz
Copy link
Member

Are you sure you are using the correct path? README states:

import fyne.io/x/fyne/widget

Calling https://fyne.io/fyne/x/widget/?go-get=1

Returns

<!DOCTYPE html>
<html>
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
        <meta name="go-import" content="fyne.io/x/fyne git https://github.com/fyne-io/fyne-x">
        <meta http-equiv="refresh" content="0; url=http://github.com/fyne-io/fyne-x">
    </head>
    <body>
        The Fyne API extensions - read the <a href="http://godoc.org/fyne.io/fyne-x">documentation</a>.
    </body>
</html>

@andydotxyz
Copy link
Member

I see now that our placeholder files were using the wrong path, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andydotxyz @AlbinoGeek