-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Python 3.9 support #190
Conversation
18ea0de
to
a3d73ae
Compare
Codecov ReportBase: 69.31% // Head: 69.31% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #190 +/- ##
========================================
Coverage 69.31% 69.31%
========================================
Files 7 7
Lines 290 290
Branches 50 50
========================================
Hits 201 201
Misses 82 82
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Shouldn't the commit type be
chore
instead offeat
? - In the commit message, can you add an empty line before
Ref:
so that Git is able to recognizeRef:
as a trailer?
- Add version to Setuptools script. - Add Tox environment. - Add version to CI configuration. - Update Docker Compose configuration. - Update Make task for running tests: `docker-compose-run-test`. More info: https://docs.python.org/3.9/whatsnew/3.9.html Ref: https://cordada.aha.io/features/COMPCLDATA-162
a3d73ae
to
f6e4333
Compare
Your call, I used as reference a PR in this repository (#13), which classified as |
Good point. I guess that adding support for a new Python version could be considered a feature. |
docker-compose-run-test
.More info: https://docs.python.org/3.9/whatsnew/3.9.html
Ref: https://cordada.aha.io/features/COMPCLDATA-162