Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Python 3.9 support #190

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

ycouce-cdd
Copy link
Member

@ycouce-cdd ycouce-cdd commented Nov 8, 2022

  • Add version to Setuptools script.
  • Add Tox environment.
  • Add version to CI configuration.
  • Update Docker Compose configuration.
  • Update Make task for running tests: docker-compose-run-test.

More info: https://docs.python.org/3.9/whatsnew/3.9.html

Ref: https://cordada.aha.io/features/COMPCLDATA-162

@codecov-commenter
Copy link

Codecov Report

Base: 69.31% // Head: 69.31% // No change to project coverage 👍

Coverage data is based on head (a3d73ae) compared to base (89784d8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #190   +/-   ##
========================================
  Coverage    69.31%   69.31%           
========================================
  Files            7        7           
  Lines          290      290           
  Branches        50       50           
========================================
  Hits           201      201           
  Misses          82       82           
  Partials         7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ycouce-cdd ycouce-cdd marked this pull request as ready for review November 10, 2022 16:01
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Shouldn't the commit type be chore instead of feat?
  • In the commit message, can you add an empty line before Ref: so that Git is able to recognize Ref: as a trailer?

- Add version to Setuptools script.
- Add Tox environment.
- Add version to CI configuration.
- Update Docker Compose configuration.
- Update Make task for running tests: `docker-compose-run-test`.

More info: https://docs.python.org/3.9/whatsnew/3.9.html

Ref: https://cordada.aha.io/features/COMPCLDATA-162
@ycouce-cdd
Copy link
Member Author

  • Shouldn't the commit type be chore instead of feat?

Your call, I used as reference a PR in this repository (#13), which classified as feature these changes, according to the branch name.
If we now use new guidelines, I can change it, but the branch name would still be prefixed with feature.

@jtrobles-cdd
Copy link
Member

  • Shouldn't the commit type be chore instead of feat?

Your call, I used as reference a PR in this repository (#13), which classified as feature these changes, according to the branch name. If we now use new guidelines, I can change it, but the branch name would still be prefixed with feature.

Good point. I guess that adding support for a new Python version could be considered a feature.

@ycouce-cdd ycouce-cdd merged commit f734cb6 into develop Nov 11, 2022
@ycouce-cdd ycouce-cdd deleted the feature/add-python-3.9-support branch November 11, 2022 18:39
@ycouce-cdd ycouce-cdd mentioned this pull request Nov 11, 2022
@jtrobles-cdd jtrobles-cdd added enhancement New feature or request and removed feature labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants