This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Fix: Reduce visibility of setUp() and tearDown() #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/visibility
branch
from
d4b785e
to
7064f56
Compare
localheinz
force-pushed
the
fix/visibility
branch
from
7064f56
to
a3dfa06
Compare
fzaninotto
approved these changes
Nov 27, 2019
pimjansen
approved these changes
Nov 28, 2019
|
Thank you, @fzaninotto and @pimjansen! |
Partoo
added a commit
to Partoo/Faker
that referenced
this pull request
Jun 21, 2020
* 'master' of github.com:Partoo/Faker: (294 commits) Fix (bug fzaninotto#1862): Do not clear entity manager for doctrine orm populator (fzaninotto#1995) Remove persian rude words. (fzaninotto#1879) Enhancement: Run builds on master using GitHub Actions Fix typo (fzaninotto#1927) Fix: Run build against PHP 7.4 Fix: Aggregate badges in one place (fzaninotto#1866) Added changelog for the 1.9.1 release Fix: Reduce visibility of setUp() and tearDown() (fzaninotto#1821) Enhancement: Collect code coverage (fzaninotto#1824) Enhancement: Use all columns when running tests Add link to PHPStan extension to readme (fzaninotto#1834) Enhancement: Configure verbose output via phpunit.xml.dist Update master version Bump version to 1.9 Curly braces for arrays is deprecated in PHP 7.4 (detected by PHPCompatibility) Updated indenting changelog Update changelog with 1.9.0 release Skipped lorumpixel test for the release where the service is pretty unstable Fix: Mark test classes as final Fix: Remove unnecessary class-level DocBlocks ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
setUp()andtearDown()frompublictoprotected馃拋鈥嶁檪 This is the visibility as declared on
PHPUnit\Framework\TestCase, and there's probably no need to increase it.