Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix (bug #1862): Do not clear entity manager for doctrine orm populator #1995

Merged
merged 1 commit into from May 11, 2020
Merged

Conversation

jlekowski
Copy link
Contributor

Bug: #1862
Clear specific entities is deprecated and will not be supported in Doctrine 3.0. (doctrine/orm@9ccb883)
Bug introduced: c49cd54
Related issue: https://stackoverflow.com/questions/18215975/doctrine-a-new-entity-was-found-through-the-relationship

@jlekowski
Copy link
Contributor Author

I tested that on my project with different batch sizes, but I don't generate many records.

Alternatively the whole c49cd54 (batchSize option) could be reverted.

@pimjansen pimjansen merged commit 5337ce5 into fzaninotto:master May 11, 2020
Partoo added a commit to Partoo/Faker that referenced this pull request Jun 21, 2020
* 'master' of github.com:Partoo/Faker: (294 commits)
  Fix (bug fzaninotto#1862): Do not clear entity manager for doctrine orm populator (fzaninotto#1995)
  Remove persian rude words. (fzaninotto#1879)
  Enhancement: Run builds on master using GitHub Actions
  Fix typo (fzaninotto#1927)
  Fix: Run build against PHP 7.4
  Fix: Aggregate badges in one place (fzaninotto#1866)
  Added changelog for the 1.9.1 release
  Fix: Reduce visibility of setUp() and tearDown() (fzaninotto#1821)
  Enhancement: Collect code coverage (fzaninotto#1824)
  Enhancement: Use all columns when running tests
  Add link to PHPStan extension to readme (fzaninotto#1834)
  Enhancement: Configure verbose output via phpunit.xml.dist
  Update master version
  Bump version to 1.9
  Curly braces for arrays is deprecated in PHP 7.4 (detected by PHPCompatibility)
  Updated indenting changelog
  Update changelog with 1.9.0 release
  Skipped lorumpixel test for the release where the service is pretty unstable
  Fix: Mark test classes as final
  Fix: Remove unnecessary class-level DocBlocks
  ...
mingalevme pushed a commit to mingalevme/Faker that referenced this pull request Sep 29, 2020
GrahamCampbell pushed a commit to FakerPHP/Faker that referenced this pull request Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants