Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix: Aggregate badges in one place #1866

Merged
merged 1 commit into from Dec 17, 2019
Merged

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 3, 2019

This PR

  • aggregates build status and similar badges in a single place

@codecov-io
Copy link

Codecov Report

Merging #1866 into master will increase coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1866      +/-   ##
============================================
+ Coverage     56.48%   57.92%   +1.44%     
  Complexity     2068     2068              
============================================
  Files           306      306              
  Lines          4851     4851              
============================================
+ Hits           2740     2810      +70     
+ Misses         2111     2041      -70
Impacted Files Coverage Δ Complexity Δ
src/Faker/Provider/th_TH/Person.php 0% <0%> (-28.58%) 3% <0%> (ø)
src/Faker/Provider/ar_JO/Company.php 0% <0%> (-16.67%) 5% <0%> (ø)
src/Faker/Provider/en_ZA/PhoneNumber.php 90.9% <0%> (-9.1%) 17% <0%> (ø)
src/Faker/Provider/ru_RU/Company.php 92% <0%> (-8%) 12% <0%> (ø)
src/Faker/Provider/zh_TW/Address.php 40.74% <0%> (-7.41%) 12% <0%> (ø)
src/Faker/Provider/en_HK/Address.php 66.66% <0%> (ø) 9% <0%> (ø) ⬇️
src/Faker/Provider/ms_MY/Person.php 67.92% <0%> (ø) 24% <0%> (ø) ⬇️
src/Faker/Provider/hu_HU/Address.php 46.15% <0%> (ø) 6% <0%> (ø) ⬇️
src/Faker/Provider/ms_MY/Company.php 50% <0%> (ø) 2% <0%> (ø) ⬇️
src/Faker/Provider/nl_NL/Person.php 65.78% <0%> (+2.63%) 15% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f10e4...727e612. Read the comment docs.

@pimjansen pimjansen added this to the 1.9.2 milestone Dec 3, 2019
@pimjansen pimjansen merged commit 7a6797d into fzaninotto:master Dec 17, 2019
@pimjansen
Copy link
Contributor

Thanks!

@localheinz localheinz deleted the fix/badge branch December 17, 2019 13:52
@localheinz
Copy link
Contributor Author

Thank you, @fzaninotto and @pimjansen!

Partoo added a commit to Partoo/Faker that referenced this pull request Jun 21, 2020
* 'master' of github.com:Partoo/Faker: (294 commits)
  Fix (bug fzaninotto#1862): Do not clear entity manager for doctrine orm populator (fzaninotto#1995)
  Remove persian rude words. (fzaninotto#1879)
  Enhancement: Run builds on master using GitHub Actions
  Fix typo (fzaninotto#1927)
  Fix: Run build against PHP 7.4
  Fix: Aggregate badges in one place (fzaninotto#1866)
  Added changelog for the 1.9.1 release
  Fix: Reduce visibility of setUp() and tearDown() (fzaninotto#1821)
  Enhancement: Collect code coverage (fzaninotto#1824)
  Enhancement: Use all columns when running tests
  Add link to PHPStan extension to readme (fzaninotto#1834)
  Enhancement: Configure verbose output via phpunit.xml.dist
  Update master version
  Bump version to 1.9
  Curly braces for arrays is deprecated in PHP 7.4 (detected by PHPCompatibility)
  Updated indenting changelog
  Update changelog with 1.9.0 release
  Skipped lorumpixel test for the release where the service is pretty unstable
  Fix: Mark test classes as final
  Fix: Remove unnecessary class-level DocBlocks
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants