This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
ro_RO Person: fixed generating first and last day of year #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1942 +/- ##
============================================
- Coverage 56.58% 56.52% -0.07%
Complexity 2068 2068
============================================
Files 306 306
Lines 4851 4851
============================================
- Hits 2745 2742 -3
- Misses 2106 2109 +3
Continue to review full report at Codecov.
|
|
@fzaninotto plz have this merged, so we all can have working PR-s |
|
@fzaninotto, can we have this simple PR merged to avoid issues with tests in the future? |
…rm populator (fzaninotto#1995) Bug: fzaninotto#1862 Clear specific entities is deprecated and will not be supported in Doctrine 3.0. (doctrine/orm@9ccb883) Bug introduced: c49cd54 Related issue: https://stackoverflow.com/questions/18215975/doctrine-a-new-entity-was-found-through-the-relationship
Thanks for your contribution
* Fix IBAN generation for CR (Costa Rica)
Fix generating lastname for female gender. Changed from latin 'a' to cyrillic 'а'
Co-Authored-By: Chris Döhring <6341536+chris-doehring@users.noreply.github.com>
Updates the Danish addresses
* Other Brazilian names * Changes reverted to short array syntax
Co-authored-by: Pim Jansen <pjansen@senet.nl>
Fix: Merge files
Fix: Indentation
We label this BC break as a bug
…ion (anything older than 2017)
Added link to documentation to README.md
Co-authored-by: Nyholm <tobias.nyholm@gmail.com>
Co-authored-by: Tobias Nyholm <tobias.nyholm@gmail.com>
* Prepare release of 1.11.0 * Updated date * Added cs to change log Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
* add Singapore NRIC/FIN provider * cast number to int
…rst-and-last-day-of-year
3 tasks
…otto#64) Co-authored-by: Pim Jansen <pjansen@senet.nl> Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
…rst-and-last-day-of-year
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed in Febuary tests in all PRs fail because of Romanian Person provider.
I found out it was because the first and last day of the year was generated incorrectly.
This made the provider in one of the tests to generate non-existing date
1957-02-29which was then compared against1957-03-01PHP function
strtotime()assumes that when no month name is given, the first day of current month in the specified year is generated. Furthermore, looks like in some casesstrtotime("last day of ")was called which resulted in generating2020-02-29and then only month and day value was used to generate a date which does not exist in non-leap years.The tests are likely to pass in the following months without this update until February in next leap year which is 2024.