Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

[Feature] Add Screenshot functionality #3

Closed
ghost opened this issue May 14, 2020 · 9 comments
Closed

[Feature] Add Screenshot functionality #3

ghost opened this issue May 14, 2020 · 9 comments

Comments

@ghost
Copy link

ghost commented May 14, 2020

With MPV, the base of haruna, I can make screenshots of the current playing video. Is it possible to add this functionality to haruna?

Configuration options like save location, name, format and compression level for the file would be nice too. These options are already available in MPV.

@g-fb
Copy link
Owner

g-fb commented May 17, 2020

Added an action (s key) to take screenshots.
Screenshots are saved in a screenshots folder in the same folder as the video file.

More options will be added later, I'll leave this open until then.

0c16096

@ghost
Copy link
Author

ghost commented May 17, 2020

Thanks for your effort @g-fb ! The new shortcut works fine.

@g-fb
Copy link
Owner

g-fb commented Jul 29, 2020

Added settings to set the image format and template for name Configure > Video.
You can use the template option to change the location of the screenshots. Default is the same.
Click the help button for more info.

Quality, compression and others won't have their own options, instead I will add a feature to let people set their own properties and you will be able to use that.

@g-fb
Copy link
Owner

g-fb commented Jul 29, 2020

Updated version is on flathub.

@ghost
Copy link
Author

ghost commented Jul 29, 2020

Nice @g-fb ! It kinda works on my end. Some things I noticed:

  • Setting the image format does nothing on my end. it always saves as jpg. My template looks like this: /home/test/Bilder/%F %p
  • The option to set the image folder in a separate input would be more user friendly
  • An option to set compression would be nice too as the images get compressed a lot.

Other then that, it works fine.

@g-fb
Copy link
Owner

g-fb commented Jul 29, 2020

Setting the image format does nothing on my end. it always saves as jpg. My template looks like this: /home/test/Bilder/%F %p

That's because I forgot to set it on startup.

The option to set the image folder in a separate input would be more user friendly

I rather not add another box when the existing one already handles this and once I add the custom properties feature you can set the screenshot-directory property. Also if you don't enter an absolute path in the field it starts from your home folder, so you can set it to Bilder/%F %p and it should be the same.

An option to set compression would be nice too as the images get compressed a lot.

Originally I had added this but there were no big changes except between the smallest and biggest values. And again the custom properties will allow you to do this.

@ghost
Copy link
Author

ghost commented Jul 29, 2020

Okay, I will close the ticket, when the image format issue is solved as the other functions will come later.

@g-fb
Copy link
Owner

g-fb commented Jul 30, 2020

Should be fixed now.

@ghost
Copy link
Author

ghost commented Jul 30, 2020

I can confirm that it is fixed.

@ghost ghost closed this as completed Jul 30, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant