Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Match Titles are cut off #30

Open
ted537 opened this issue Jul 12, 2022 · 3 comments
Open

Bug: Match Titles are cut off #30

ted537 opened this issue Jul 12, 2022 · 3 comments

Comments

@ted537
Copy link
Contributor

ted537 commented Jul 12, 2022

image

On version 1.0.18-beta.1
@ted537
Copy link
Contributor Author

ted537 commented Jul 12, 2022

Observed on chrome Version 101.0.4951.64 (Official Build) (64-bit) and Firefox 102.0 (64-bit)

@ted537
Copy link
Contributor Author

ted537 commented Jul 12, 2022

I was able to resolve this by overriding boxHeight but maybe the font-size / line-height CSS should be reset at the root of the viewer (if that's possible) such that the default boxHeight works, regardless of what I've set my external (HTML/<body>) font size to.

@Shenato
Copy link
Contributor

Shenato commented Aug 20, 2022

That sounds like a good suggestion to solve this issue, as long as it would still allow for full customizability of the font-size/line-height by the consumer. I will see if I will get time to look into. However feel free to submit a PR if you want to and I would be happy to merge it in. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ted537 @Shenato