Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Request] Git #20

Closed
heavyutils opened this issue May 4, 2024 · 2 comments
Closed

[Change Request] Git #20

heavyutils opened this issue May 4, 2024 · 2 comments

Comments

@heavyutils
Copy link

The references to git in the vcxproj (and in the code, for that matter) screw up compilation totally. Following the steps you provided and ensuring Git is properly installed will always return an error when compiling. I found out myself that removing all the git references from the vcxproj and code referencing gitparams.h solves all the issues.

For convenience of other contributors (now I know it), I recommend that the Git code will be removed. It is not very hard to manually upload the project files. Maybe a little inconvenient at first, but trust me, contributors will thank you.

@heavyutils heavyutils changed the title Git [Change Request] Git May 5, 2024
@g0aty
Copy link
Owner

g0aty commented May 6, 2024

That works like a charm, I will implement it in the next update.

@g0aty
Copy link
Owner

g0aty commented May 7, 2024

Changed for convenience :D

@g0aty g0aty closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants