Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please upgrade this library to .Net core 2.0? #35

Closed
svpatel401 opened this issue Sep 5, 2017 · 9 comments
Closed

please upgrade this library to .Net core 2.0? #35

svpatel401 opened this issue Sep 5, 2017 · 9 comments

Comments

@svpatel401
Copy link

I have tried to upgrade this class library to .Net core 2.0, without any issue.

In sample application, we have extension method - AddIdentityWithMongoStore. I was not able to find any reference to this on github code shared by you. Where is file MongoIdentityBuilderExtensions?

 // Register identity framework services and also Mongo storage. 
	        services.AddIdentityWithMongoStores(Configuration.GetConnectionString("DefaultConnection"))
		        .AddDefaultTokenProviders();

Appreciate if you can upgrade the library along with sharing code for MongoIdentityBuilderExtensions.

Thank you.

@vladimir-kucher
Copy link

Same thing here. Need this project under .net core 2.0. Please update!

@codepoc
Copy link

codepoc commented Sep 7, 2017

@g0t4 - Hope you are doing great. I am running into same issue. Appreciate your insight. Thanks a lot.

@kenyeung128
Copy link

same here thanks @g0t4

@nrhoffmann
Copy link

nrhoffmann commented Sep 15, 2017

same here @g0t4

@nohwnd
Copy link

nohwnd commented Sep 17, 2017

@svpatel401 The code is there, it is just not on the master branch. I am successfully using this library build from sources with .NET Core 2.0 app, but it would be nice to have it available on nuget.

@svpatel401
Copy link
Author

@nohwnd - Thank you much. Can someone give this man a trophy - he deserves it.

@g0t4
Copy link
Owner

g0t4 commented Sep 18, 2017

I'll have a chance to look at this Thursday. I'm swamped until then.

Did the APIs change?

If not this should be compatible with netcoreapp2.0 by adding a package reference.

@svpatel401
Copy link
Author

@g0t4 Missing piece of info according to me is "MongoIdentityBuilderExtensions", which then be pointed by @nohwnd

Few suggestions to make this lib even better:

  1. Change the namespace, so that it doesn't look like it is coming from Microsoft. (It was much confusing in the beginning)
  2. Add ApplicationUser class to the library, so that test web application doesn't have any change, except deleting existing ApplicationUser class. (This are giving some wired errors because by default we are using IdentityUser in library). Solution: would be either change things in test web application or library. I would prefer changing in library to keep things as simple as possible.
An unhandled exception occurred while processing the request.

InvalidOperationException: No service for type 'Microsoft.AspNetCore.Identity.UserManager`1[TestMvcWebApp.Models.ApplicationUser]' has been registered.
Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)

@razzeee
Copy link

razzeee commented Sep 27, 2017

I also think the namespace change would be a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants