Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oAuth login pure.css cdn broken #8

Closed
RoboSparrow opened this issue Jul 14, 2015 · 4 comments
Closed

oAuth login pure.css cdn broken #8

RoboSparrow opened this issue Jul 14, 2015 · 4 comments
Assignees
Milestone

Comments

@RoboSparrow
Copy link
Member

pure css cdn doesn't not support https (Error code: ssl_error_bad_cert_domain), so the css wont load

We need either to fetch it from a different cdn or include it locally.

Options:

This issue actually relates to a discussion we had about allowing LRS owners to plug-in their own theme/branding of OAuth, so maybe we tackle issue and enhancement in 0.9.1.

  • expose a number of twig vars to config.yaml
  • expose logo image destination to config.yaml
  • provide a custom.css overwrite path and custom.js path
@RoboSparrow RoboSparrow added this to the 0.9.0 milestone Jul 14, 2015
@sraka1
Copy link
Contributor

sraka1 commented Jul 14, 2015

  • expose logo image destination to config.yaml
  • provide a custom.css overwrite path and custom.js path

This is already implemented.

  • expose a number of twig vars to config.yaml

Which Twig vars for example?

Will also change CDM (SSL) and apply.

@RoboSparrow
Copy link
Member Author

Which Twig vars for example?

  • brandName (text)
  • brandImage (path)
  • pageTop (below h1, markup)
  • formTop(text)
  • formBottom (above submit button, text)
  • pageFooter (markup)

@RoboSparrow RoboSparrow added proposal and removed bug labels Jul 14, 2015
@RoboSparrow
Copy link
Member Author

Maybe the better way would be:

  • expose optional template replacement path(s) to config.yaml
  • provide example templates with the required vars.
  • onRequest: check if custom tpl exists and include this instead of the lxHive template

This way the owner has full freedom to customize markup and content of the template and can also replace/extends css and js. Maybe we can even omit the config and do the check by default (for a defined user theme directory)

What do you think?

@RoboSparrow
Copy link
Member Author

Closing this. Resolved for this milestone. Extended theme configuration: 0.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants