Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default expiry time is incorrect for temporary access tokens #228

Closed
mdeboer opened this issue Apr 16, 2018 · 1 comment
Closed

Default expiry time is incorrect for temporary access tokens #228

mdeboer opened this issue Apr 16, 2018 · 1 comment
Milestone

Comments

@mdeboer
Copy link
Contributor

mdeboer commented Apr 16, 2018

The documentation on temporary access tokens states that the default expiry time is set to 3600 seconds (1 hour). This is not true as it's set to null by default when the parameter has been omitted from the request.

See https://github.com/Brightcookie/lxHive/blob/master/src/xAPI/Service/Auth/Basic.php#L168

@RoboSparrow
Copy link
Member

Thanks for picking this up. I corrected the wiki for now. The real fix, however, is to set the default 1h period programmatically with the next version bump.

@RoboSparrow RoboSparrow removed their assignment Nov 17, 2018
@mdeboer mdeboer closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants