-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oAuth login pure.css cdn broken #8
Comments
This is already implemented.
Which Twig vars for example? Will also change CDM (SSL) and apply. |
|
Maybe the better way would be:
This way the owner has full freedom to customize markup and content of the template and can also replace/extends css and js. Maybe we can even omit the config and do the check by default (for a defined user theme directory) What do you think? |
Closing this. Resolved for this milestone. Extended theme configuration: 0.9.2 |
pure css cdn doesn't not support https (Error code: ssl_error_bad_cert_domain), so the css wont load
We need either to fetch it from a different cdn or include it locally.
Options:
This issue actually relates to a discussion we had about allowing LRS owners to plug-in their own theme/branding of OAuth, so maybe we tackle issue and enhancement in 0.9.1.
The text was updated successfully, but these errors were encountered: