Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you add a working version of this as a demo please? #3

Closed
amyadzuki opened this issue Jul 7, 2018 · 3 comments
Closed

Could you add a working version of this as a demo please? #3

amyadzuki opened this issue Jul 7, 2018 · 3 comments

Comments

@amyadzuki
Copy link

I tried to make trivial changes to hellog3n to change the "up" direction from +Y to +Z, but it did not turn out as expected. I have tried to fix it for 2 days with no luck. I think it would be really helpful if a working demo of my failed attempt could be added to the demos. Here is a repo where you can see my three changes clearly marked in source and also documented in the included README.md: g3n-helpme-1

In brief, my three changes were:

  1. Change the camera position so that it is in the same place relative to the viewer after changing the "up" direction from +Y to +Z
  2. Change the "up" direction from +Y to +Z
  3. Use a tapered cylinder instead of a sphere so the change can be seen more clearly
@danaugrs
Copy link
Member

danaugrs commented Jul 9, 2018

Hi Amy!

Thank you for your organization - made it really easy to reproduce.
After spending several hours on this myself and practically rewriting the camera logic and matrix math, I figured it out. The camera was not being added to the scene in the original hellog3n program.
I fixed it here f234465.

At least this was a great to way to review the camera math and heavily simplify it 😄.
I'll polish and commit those changes later.

Let me know if you have any more issues!
Also, feel free to join our Slack channel (you can register here).

@danaugrs
Copy link
Member

danaugrs commented Jul 9, 2018

I just fixed it (g3n/engine@646439a) so that it works even when the camera is not added to the scene.
Therefore your original changes should work with the latest version of the engine.
Please get latest and let me know if things are behaving properly for you!

@danaugrs danaugrs closed this as completed Jul 9, 2018
@amyadzuki
Copy link
Author

Ooh what great news to wake up to! I just checked and it works beautifully now!!
Thank you so so much for all your hard work ^_^

I'm not sure what Slack is but I will join later today too, thanks for the invitation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants