Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

PgUsers.java:106-112: This class represents details about... #53

Open
0pdd opened this issue Jun 25, 2019 · 13 comments
Open

PgUsers.java:106-112: This class represents details about... #53

0pdd opened this issue Jun 25, 2019 · 13 comments
Labels
bug Something isn't working pdd scope waiting

Comments

@0pdd
Copy link

0pdd commented Jun 25, 2019

The puzzle 18-891197cc from #18 has to be resolved:

* @todo #18:30min This class represents details about a user stored in
* the database. Callers of PgUser.telegram relies on the datastructure
* defined here and must know how it is structured to exploit the
* information. Instead, extract interface from it and use it
* everywhere it is needed instead of exposing this data. One
* implementation is maybe based on Chat and another would be based on
* a pg request for example. Add unit tests for both when it's done.

The puzzle was created by @rultor on 25-Jun-19.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link

0crat commented Jun 25, 2019

@g4s8/z please, pay attention to this issue

@g4s8 g4s8 added the bug Something isn't working label Jul 10, 2019
@0crat 0crat added the scope label Jul 10, 2019
@0crat
Copy link

0crat commented Jul 10, 2019

Job #53 is now in scope, role is DEV

@0crat
Copy link

0crat commented Jul 12, 2019

The job #53 assigned to @olenagerasimova/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link

0crat commented Jul 12, 2019

Job gh:g4s8/ghman#53 already assigned to @olenagerasimova, can't assign to @olenagerasimova

@0crat
Copy link

0crat commented Jul 12, 2019

Job gh:g4s8/ghman#53 already assigned to @olenagerasimova, can't assign to @olenagerasimova

olenagerasimova added a commit to olenagerasimova/ghman that referenced this issue Jul 13, 2019
@victornoel
Copy link
Contributor

@0pdd as a complement: The todo is about extracting an interface from JsonUserDetails (could be named UserDetails?) and bring the inner class out of the PgUsers class in order to make it public and write unit tests for it.

olenagerasimova added a commit to olenagerasimova/ghman that referenced this issue Jul 16, 2019
@olenagerasimova
Copy link
Contributor

@0crat wait for #72 review/merge

@0crat 0crat added the waiting label Jul 16, 2019
@0crat
Copy link

0crat commented Jul 16, 2019

@0crat wait for #72 review/merge (here)

@olenagerasimova The impediment for #53 was registered successfully by @olenagerasimova/z

olenagerasimova added a commit to olenagerasimova/ghman that referenced this issue Jul 17, 2019
olenagerasimova added a commit to olenagerasimova/ghman that referenced this issue Jul 17, 2019
olenagerasimova added a commit to olenagerasimova/ghman that referenced this issue Jul 29, 2019
@victornoel
Copy link
Contributor

@g4s8 @olenagerasimova following the discussion in #72 (comment), I believe that the best course of action is to not solve this @todo but simply remove it and forget about it.
For the record, this is so because this @todo was incorrectly introduced.

@olenagerasimova
Copy link
Contributor

@0crat refuse

@olenagerasimova
Copy link
Contributor

@0crat status

@0crat
Copy link

0crat commented Apr 15, 2020

@0crat status (here)

@olenagerasimova This is what I know about this job in CJT4R32Q3, as in §32:

@0crat
Copy link

0crat commented Apr 15, 2020

@0crat refuse (here)

@olenagerasimova The user @olenagerasimova/z resigned from #53, please stop working. Reason for job resignation: Order was cancelled

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working pdd scope waiting
Projects
None yet
Development

No branches or pull requests

5 participants