Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build date via ldflags #17

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Add build date via ldflags #17

merged 1 commit into from
Jun 22, 2019

Conversation

vassilevsky
Copy link
Contributor

@vassilevsky vassilevsky commented Jun 20, 2019

GoReleaser conveniently has the date field in RFC3339 format, which is very similar to ISO 🙃

https://goreleaser.com/customization/#Name%20Templates

@0crat
Copy link

0crat commented Jun 20, 2019

@g4s8/z please, pay attention to this pull request

@0crat
Copy link

0crat commented Jun 20, 2019

@vassilevsky/z this pull request is too small, just 9 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @g4s8/z please review this and merge or reject

@g4s8
Copy link
Owner

g4s8 commented Jun 21, 2019

@vassilevsky thanks, looks good, just few comments about PR style:

  1. Please don't use Github keywords in PRs, such as closes #6 - 0crat will pay only if the ticket is closed by author or ARC, when you use closes keyword, the ticket will be closed by rultor merge bot and 0crat won't pay.
  2. Add issue number to the commit message to be able to understand ticket number for any change later, it should look like: #6 - Add build date via ldflags

@vassilevsky
Copy link
Contributor Author

I've fixed these issues 🤓

@g4s8
Copy link
Owner

g4s8 commented Jun 22, 2019

@vassilevsky thanks

@g4s8
Copy link
Owner

g4s8 commented Jun 22, 2019

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 22, 2019

@rultor merge

@g4s8 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c51125f into g4s8:master Jun 22, 2019
@rultor
Copy link
Contributor

rultor commented Jun 22, 2019

@rultor merge

@g4s8 Done! FYI, the full log is here (took me 2min)

@0crat
Copy link

0crat commented Jun 22, 2019

Job gh:g4s8/gitstrap#17 is not assigned, can't get performer

@0crat
Copy link

0crat commented Jun 22, 2019

This job is not in scope

@vassilevsky vassilevsky deleted the build-date branch June 24, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants