-
Notifications
You must be signed in to change notification settings - Fork 114
Conversation
This removes redundant code and will make the schemas python module much easier to use. |
8b89125
to
008b8d3
Compare
@david4096 ready for review |
Actually, hold on... there's a few problems. https://travis-ci.org/ga4gh/server/builds/199079898 I need to add the |
008b8d3
to
7135700
Compare
7135700
to
3626f2d
Compare
@david4096 ok, should be good now |
CI is failing and I'm not able to replicate locally. It seems like it might be a CI bug working off a different commit? Gonna try closing and reopening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dcolligan. This will move some code that is used across GA4GH installatations (protocol serialization, route information) into the python module. We should be looking for ways to remove the hack and the rewrites we do to the paths. For now I'm glad to have this.
This PR moves some code out of the server and so the PR to attend it is here ga4gh/ga4gh-server#1547 .
Issue BD2KGenomics/ga4gh-integration-deprecated#53