Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Add protocol.py #801

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Add protocol.py #801

merged 1 commit into from
Feb 7, 2017

Conversation

dcolligan
Copy link
Member

@dcolligan dcolligan commented Jan 26, 2017

@david4096
Copy link
Member

This removes redundant code and will make the schemas python module much easier to use.

@kozbo kozbo added this to the 2017-00 v0.6.0a10 milestone Feb 2, 2017
@dcolligan dcolligan force-pushed the without_protocol branch 3 times, most recently from 8b89125 to 008b8d3 Compare February 7, 2017 03:14
@dcolligan
Copy link
Member Author

@david4096 ready for review

@dcolligan
Copy link
Member Author

Actually, hold on... there's a few problems.

https://travis-ci.org/ga4gh/server/builds/199079898

I need to add the encodeValue and setAttribute methods and fix getValueFromValue

@dcolligan
Copy link
Member Author

@david4096 ok, should be good now

@david4096
Copy link
Member

CI is failing and I'm not able to replicate locally. It seems like it might be a CI bug working off a different commit? Gonna try closing and reopening.

Copy link
Member

@david4096 david4096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dcolligan. This will move some code that is used across GA4GH installatations (protocol serialization, route information) into the python module. We should be looking for ways to remove the hack and the rewrites we do to the paths. For now I'm glad to have this.

This PR moves some code out of the server and so the PR to attend it is here ga4gh/ga4gh-server#1547 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants