Skip to content
This repository has been archived by the owner on Apr 27, 2018. It is now read-only.

Move parts of protocol.py into ga4gh-schemas repo? #53

Closed
dcolligan opened this issue Jan 10, 2017 · 3 comments
Closed

Move parts of protocol.py into ga4gh-schemas repo? #53

dcolligan opened this issue Jan 10, 2017 · 3 comments
Assignees
@dcolligan

Comments

@dcolligan
Copy link
Collaborator

Rethink how pb.py, protocol.py and the pb2 files relate to each other; there could be a better way to structure things.

Originally filed in https://github.com/dcolligan/ga4gh-schemas/issues/1
@dcolligan dcolligan self-assigned this Jan 10, 2017
@david4096
Copy link
Member

There are a couple of things we can include to make using the schemas alone easier, and the protocol serialization parts should be shared.

dcolligan added a commit to dcolligan/ga4gh-schemas that referenced this issue Jan 26, 2017
@dcolligan
Add protocol.py
613d763 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
@dcolligan dcolligan mentioned this issue Jan 26, 2017
Merged
dcolligan added a commit to dcolligan/ga4gh-client that referenced this issue Jan 26, 2017
@dcolligan
Remove protocol.py
eb3c0e6 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
@dcolligan dcolligan mentioned this issue Jan 26, 2017
Merged
dcolligan added a commit to dcolligan/ga4gh-server that referenced this issue Jan 26, 2017
@dcolligan
Remove protocol.py
011160c 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
@dcolligan dcolligan mentioned this issue Jan 26, 2017
Merged
dcolligan added a commit to dcolligan/ga4gh-server that referenced this issue Jan 26, 2017
@dcolligan
Remove protocol.py
b97b9dd 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-schemas that referenced this issue Feb 7, 2017
@dcolligan
Add protocol.py
ed2c331 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-schemas that referenced this issue Feb 7, 2017
@dcolligan
Add protocol.py
8b89125 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-schemas that referenced this issue Feb 7, 2017
@dcolligan
Add protocol.py
008b8d3 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-server that referenced this issue Feb 7, 2017
@dcolligan
Remove protocol.py
b89cdeb 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-client that referenced this issue Feb 7, 2017
@dcolligan
Remove protocol.py
7be8379 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-schemas that referenced this issue Feb 7, 2017
@dcolligan
Add protocol.py
7135700 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-schemas that referenced this issue Feb 7, 2017
@dcolligan
Add protocol.py
3626f2d 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
david4096 pushed a commit to ga4gh/ga4gh-schemas that referenced this issue Feb 7, 2017
@dcolligan @david4096
Add protocol.py (#801)
958f0ba 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
@david4096
Copy link
Member

david4096 commented Feb 7, 2017 •
edited
Loading

@dcolligan Thanks for this! We can close when the PR on server and client are merged.

dcolligan added a commit to dcolligan/ga4gh-client that referenced this issue Feb 8, 2017
@dcolligan
Remove protocol.py
4592d5c 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-server that referenced this issue Feb 8, 2017
@dcolligan
Remove protocol.py
5a3900a 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
dcolligan added a commit to dcolligan/ga4gh-server that referenced this issue Feb 8, 2017
@dcolligan
Remove protocol.py
fe777d2 
Issue BD2KGenomics/ga4gh-integration-deprecated#53
@dcolligan
Copy link
Collaborator Author

Fixed in:

ga4gh/ga4gh-schemas#801
ga4gh/ga4gh-server#1547
ga4gh/ga4gh-client#56

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dcolligan dcolligan

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@david4096 @dcolligan