Proposal: add "backend_parameters" to tesResources #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattMcL4475
changed the title
MattMcL4475
changed the title
… any unsupported kvs are passed to backend_parameters
aniewielska
approved these changes
Feb 14, 2022
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the WDL spec, "The runtime section defines key/value pairs for runtime information needed for this task":
https://github.com/openwdl/wdl/blob/master/versions/1.0/SPEC.md#runtime-section
This commit extends tesResources to support an arbitrary dictionary of additional properties, which ensures WDL parsers can pass-through their full list of runtime key/value pairs to a TES backend. The canonical example of its use would be for WDL authors to be able to specify a specific cloud VM SKU in their WDL files.
Please see previous closed PR for discussion: #127