Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: models.yaml to take ordered property in account #409

Merged
merged 2 commits into from Nov 8, 2022
Merged

fix: models.yaml to take ordered property in account #409

merged 2 commits into from Nov 8, 2022

Conversation

korikuzma
Copy link
Contributor

@korikuzma korikuzma commented Oct 31, 2022 •
edited

Updating models.yaml to take into account the ordered property in array fields.

The docs will be updated with this new rule in #410

@korikuzma korikuzma self-assigned this Oct 31, 2022
@korikuzma korikuzma marked this pull request as ready for review November 2, 2022 12:54
@ahwagner ahwagner requested a review from reece November 2, 2022 12:56
reece
reece approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@reece reece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but I didn't run anything... lmk if you'd like me to do that)

@korikuzma
Copy link
Contributor Author

@reece do you agree with #410? If not, we should discuss further on that issue and I should make the appropriate changes before merging this PR.

@reece
Copy link
Member

reece commented Nov 3, 2022

I wasn't aware of the ordered property. I commented on #410. Thanks for raising it.

This was referenced Nov 3, 2022
Open
Closed
@korikuzma
Copy link
Contributor Author

@ahwagner @reece @larrybabb @andreasprlic I updated models.yaml from discussion in #410 . The corresponding vrs-python changes can be seen in this PR. Let me know if any additional changes need to be made.

@korikuzma korikuzma mentioned this pull request Nov 8, 2022
Merged
@korikuzma korikuzma merged commit ebcf629 into main Nov 8, 2022
@korikuzma korikuzma deleted the fix-models branch November 8, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reece reece reece approved these changes

@ahwagner ahwagner ahwagner approved these changes

@andreasprlic andreasprlic Awaiting requested review from andreasprlic andreasprlic is a code owner

@larrybabb larrybabb Awaiting requested review from larrybabb larrybabb is a code owner

Assignees

@korikuzma korikuzma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@korikuzma @reece @ahwagner