Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming on the graph causes predicted values to change #7

Open
baobabKoodaa opened this issue Mar 28, 2020 · 0 comments
Open

Zooming on the graph causes predicted values to change #7

baobabKoodaa opened this issue Mar 28, 2020 · 0 comments

Comments

@baobabKoodaa
Copy link

baobabKoodaa commented Mar 28, 2020

Hey, I really love this calculator and I think this is an amazing piece of work! I noticed this minor issue and I would be happy to provide a PR for it if you'd be interested?

I noticed that the generation of values is tied to the presentation of values (to be specific, it's tied to the timestep/zoom of the graph). For example, using the default parameters and default zoom, day 100 infected count is 66,006. But if you zoom in on the graph so that day 100 is the last day shown, the infected count changes and is now 66,977. This appears to happen because, although the label says "day 100", it might actually be "day 100.38" (or whatever, depending on the timestep).

I think generation of values should be entirely separated from the presentation of values: generate values for all the days and then show values for the desired days. With this change the predictions don't change depending on the zoom. This change would also require tweaking the way zooming works on the graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant