Crashed when closing app

[qsyttkx]

scene:

When the main function is returned, a detached thread print a log, then crashed(probabilistic occurrence).

version: spdlog-1.10.0

crashed message:

Unhandled exception thrown: read access violation.
_Mem was 0x50.

crashed stack:

std::_Atomic_storage<int,4>::load(const std::memory_order _Order) Line 912 (c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\atomic:912)
spdlog::logger::should_log(spdlog::level::level_enum msg_level) Line 303 (d:\Projects\litchi\3rd\spdlog-1.10.0\include\spdlog\logger.h:303)
spdlog::logger::log_<std::string &>(spdlog::source_loc loc, spdlog::level::level_enum lvl, fmt::v8::basic_string_view<char> fmt, std::string & <args_0>) Line 358 (d:\Projects\litchi\3rd\spdlog-1.10.0\include\spdlog\logger.h:358)
spdlog::logger::log<std::string &>(spdlog::source_loc loc, spdlog::level::level_enum lvl, fmt::v8::basic_format_string<char,std::string &> fmt, std::string & <args_0>) Line 91 (d:\Projects\litchi\3rd\spdlog-1.10.0\include\spdlog\logger.h:91)
my_function

How to avoid it?

[tt4g]

Try calling spdlog::shutdown() before exiting the application.

[qsyttkx]

Try calling spdlog::shutdown() before exiting the application.

I call spdlog::drop_all() before main() return, and it will still crash when I change it to spdlog::shutdown.

But, thank you, I found that printing logs after shutdown called triggers the crash. So I just removed drop_all/shutdown, and I am now at peace.

Is it a bug that needs to be fixed? (check if shutdown is called before logging)

[tt4g]

Is it a bug that needs to be fixed? (check if shutdown is called before logging)

No. It is by design that spdlog crashes after calling these APIs.

[beautifulnight]

I found that i need to call drop_all to reset the shared_ptr so that the registry can be destructed, otherwise the use_count of the default_logger_ will not be zero and lead to memory leak. Is that a problem or I got something wrong?

[tt4g]

@beautifulnight It is better to call, but the registry is a static variable in the function, so memory should be released.